flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6053) Gauge<T> should only take subclasses of Number, rather than everything
Date Tue, 20 Feb 2018 09:43:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369859#comment-16369859
] 

ASF GitHub Bot commented on FLINK-6053:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5501
  
    If I understand correctly, all Gauges are now registered twice? Could we just register
them once and map `Gauge<?>` always to a `StringGauge` calling `Objects.toString()`
on its value?


> Gauge<T> should only take subclasses of Number, rather than everything
> ----------------------------------------------------------------------
>
>                 Key: FLINK-6053
>                 URL: https://issues.apache.org/jira/browse/FLINK-6053
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.2.0
>            Reporter: Bowen Li
>            Assignee: Chesnay Schepler
>            Priority: Major
>             Fix For: 1.5.0
>
>
> Currently, Flink's Gauge is defined as 
> ```java
> public interface Gauge<T> extends Metric {
> 	T getValue();
> }
> ```
> But it doesn't make sense to have Gauge take generic types other than Number. And it
blocks I from finishing FLINK-6013, because I cannot assume Gauge is only about Number. So
the class should be like
> ```java
> public interface Gauge<T extends Number> extends Metric {
> 	T getValue();
> }
> ```



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message