flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...
Date Fri, 23 Feb 2018 16:31:49 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5564#discussion_r170256878
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala
---
    @@ -77,58 +73,113 @@ class RowtimeValidator(val prefix: String = "") extends DescriptorValidator
{
     object RowtimeValidator {
     
       val ROWTIME = "rowtime"
    -
    -  // per rowtime properties
    -
    -  val ROWTIME_VERSION = "version"
    -  val TIMESTAMPS_TYPE = "timestamps.type"
    -  val TIMESTAMPS_TYPE_VALUE_FROM_FIELD = "from-field"
    -  val TIMESTAMPS_TYPE_VALUE_FROM_SOURCE = "from-source"
    -  val TIMESTAMPS_TYPE_VALUE_CUSTOM = "custom"
    -  val TIMESTAMPS_FROM = "timestamps.from"
    -  val TIMESTAMPS_CLASS = "timestamps.class"
    -  val TIMESTAMPS_SERIALIZED = "timestamps.serialized"
    -
    -  val WATERMARKS_TYPE = "watermarks.type"
    -  val WATERMARKS_TYPE_VALUE_PERIODIC_ASCENDING = "periodic-ascending"
    -  val WATERMARKS_TYPE_VALUE_PERIODIC_BOUNDING = "periodic-bounding"
    -  val WATERMARKS_TYPE_VALUE_FROM_SOURCE = "from-source"
    -  val WATERMARKS_TYPE_VALUE_CUSTOM = "custom"
    -  val WATERMARKS_CLASS = "watermarks.class"
    -  val WATERMARKS_SERIALIZED = "watermarks.serialized"
    -  val WATERMARKS_DELAY = "watermarks.delay"
    +  val ROWTIME_TIMESTAMPS_TYPE = "rowtime.timestamps.type"
    +  val ROWTIME_TIMESTAMPS_TYPE_VALUE_FROM_FIELD = "from-field"
    +  val ROWTIME_TIMESTAMPS_TYPE_VALUE_FROM_SOURCE = "from-source"
    +  val ROWTIME_TIMESTAMPS_TYPE_VALUE_CUSTOM = "custom"
    +  val ROWTIME_TIMESTAMPS_FROM = "rowtime.timestamps.from"
    +  val ROWTIME_TIMESTAMPS_CLASS = "rowtime.timestamps.class"
    +  val ROWTIME_TIMESTAMPS_SERIALIZED = "rowtime.timestamps.serialized"
    +
    +  val ROWTIME_WATERMARKS_TYPE = "rowtime.watermarks.type"
    +  val ROWTIME_WATERMARKS_TYPE_VALUE_PERIODIC_ASCENDING = "periodic-ascending"
    +  val ROWTIME_WATERMARKS_TYPE_VALUE_PERIODIC_BOUNDING = "periodic-bounding"
    +  val ROWTIME_WATERMARKS_TYPE_VALUE_FROM_SOURCE = "from-source"
    +  val ROWTIME_WATERMARKS_TYPE_VALUE_CUSTOM = "custom"
    +  val ROWTIME_WATERMARKS_CLASS = "rowtime.watermarks.class"
    +  val ROWTIME_WATERMARKS_SERIALIZED = "rowtime.watermarks.serialized"
    --- End diff --
    
    `rowtime.watermarks.custom.serialized`?


---

Mime
View raw message