flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...
Date Fri, 23 Feb 2018 16:31:49 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5564#discussion_r170229569
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
---
    @@ -128,6 +165,13 @@ class DescriptorProperties(normalizeKeys: Boolean = true) {
         )
       }
     
    +  /**
    +    * Adds a table schema under the given key. This method is intended for Java code.
    +    */
    +  def putTableSchema(key: String, nameAndType: JList[JTuple2[String, String]]): Unit
= {
    --- End diff --
    
    I think we should drop the Scala equivalent method. This is not a public API class that
needs a shiny Scala interface but should be usable from Java and Scala.


---

Mime
View raw message