flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink issue #5549: [FLINK-8733][network] fix SpillableSubpartition#spillFini...
Date Fri, 23 Feb 2018 09:30:41 GMT
Github user pnowojski commented on the issue:

    In that case please remove the dead code :( If it's not covered by tests because =>
it's not important => dead code.  Someone in the future will again brake this and some
other guy will try to use it in some meaningful way and you have gigantic "wtf". Especially
that test should be trivial.


View raw message