flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery
Date Thu, 22 Feb 2018 17:42:42 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5239#discussion_r170038223
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/TaskExecutorLocalStateStoresManagerTest.java
---
    @@ -46,9 +48,15 @@ public void testCreationFromConfig() throws Exception {
     
     		final Configuration config = new Configuration();
     
    -		final String rootDirString = "localStateRoot1,localStateRoot2,localStateRoot3";
    +		String tmpDir = System.getProperty("java.io.tmpdir") + File.separator;
    --- End diff --
    
    I think it's better to use a `TemporaryFolder` if there are any files created to ensure
a proper clean up at the end of the test.


---

Mime
View raw message