flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #5558: [FLINK-8747][bugfix] The tag of waiting for floati...
Date Thu, 22 Feb 2018 17:13:38 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5558#discussion_r170027206
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
    @@ -337,6 +337,11 @@ public int getSenderBacklog() {
     		return numRequiredBuffers - initialCredit;
     	}
     
    +	@VisibleForTesting
    +	public boolean isWaitingForFloatingBuffers() {
    --- End diff --
    
    I think, this could be package-private


---

Mime
View raw message