flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #5487: [FLINK-8656] [flip6] Add modify CLI command to res...
Date Thu, 22 Feb 2018 16:26:38 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5487#discussion_r170014483
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
    @@ -447,6 +453,165 @@ public void postStop() throws Exception {
     		return CompletableFuture.completedFuture(Acknowledge.get());
     	}
     
    +	@Override
    +	public CompletableFuture<Acknowledge> rescaleJob(
    +			int newParallelism,
    +			RescalingBehaviour rescalingBehaviour,
    +			Time timeout) {
    +		final ArrayList<JobVertexID> allOperators = new ArrayList<>(jobGraph.getNumberOfVertices());
    +
    +		for (JobVertex jobVertex : jobGraph.getVertices()) {
    +			allOperators.add(jobVertex.getID());
    +		}
    +
    +		return rescaleOperators(allOperators, newParallelism, rescalingBehaviour, timeout);
    +	}
    +
    +	@Override
    +	public CompletableFuture<Acknowledge> rescaleOperators(
    --- End diff --
    
    Yes it will be necessary, once we do rescaling for individual operators. This will be
the case with the rescaling policies.


---

Mime
View raw message