flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GJL <...@git.apache.org>
Subject [GitHub] flink pull request #5451: [FLINK-8632] [flip6] Introduce generalized asynchr...
Date Wed, 21 Feb 2018 16:30:21 GMT
Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5451#discussion_r169696196
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/async/AbstractAsynchronousOperationHandlersTest.java
---
    @@ -0,0 +1,350 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.rest.handler.async;
    +
    +import org.apache.flink.api.common.JobID;
    +import org.apache.flink.api.common.time.Time;
    +import org.apache.flink.runtime.concurrent.FutureUtils;
    +import org.apache.flink.runtime.rest.HttpMethodWrapper;
    +import org.apache.flink.runtime.rest.handler.HandlerRequest;
    +import org.apache.flink.runtime.rest.handler.HandlerRequestException;
    +import org.apache.flink.runtime.rest.handler.RestHandlerException;
    +import org.apache.flink.runtime.rest.messages.EmptyMessageParameters;
    +import org.apache.flink.runtime.rest.messages.EmptyRequestBody;
    +import org.apache.flink.runtime.rest.messages.MessageHeaders;
    +import org.apache.flink.runtime.rest.messages.MessageParameters;
    +import org.apache.flink.runtime.rest.messages.MessagePathParameter;
    +import org.apache.flink.runtime.rest.messages.MessageQueryParameter;
    +import org.apache.flink.runtime.rest.messages.TriggerId;
    +import org.apache.flink.runtime.rest.messages.TriggerIdPathParameter;
    +import org.apache.flink.runtime.rest.messages.queue.QueueStatus;
    +import org.apache.flink.runtime.webmonitor.RestfulGateway;
    +import org.apache.flink.runtime.webmonitor.TestingRestfulGateway;
    +import org.apache.flink.runtime.webmonitor.retriever.GatewayRetriever;
    +import org.apache.flink.runtime.webmonitor.retriever.TestingGatewayRetriever;
    +import org.apache.flink.util.ExceptionUtils;
    +import org.apache.flink.util.FlinkException;
    +import org.apache.flink.util.TestLogger;
    +
    +import org.apache.flink.shaded.netty4.io.netty.handler.codec.http.HttpResponseStatus;
    +
    +import org.junit.Before;
    +import org.junit.Test;
    +
    +import javax.annotation.Nullable;
    +
    +import java.util.Collection;
    +import java.util.Collections;
    +import java.util.Map;
    +import java.util.Optional;
    +import java.util.concurrent.CompletableFuture;
    +import java.util.concurrent.ExecutionException;
    +
    +import static org.hamcrest.Matchers.containsString;
    +import static org.hamcrest.Matchers.is;
    +import static org.junit.Assert.assertThat;
    +import static org.junit.Assert.fail;
    +
    +/**
    + * Tests for the {@link AbstractAsynchronousOperationHandlers}.
    + */
    +public class AbstractAsynchronousOperationHandlersTest extends TestLogger {
    +
    +	private static final CompletableFuture<String> localRestAddress = CompletableFuture.completedFuture("localhost");
    +
    +	private static final Time timeout = Time.seconds(10L);
    +
    +	private TestingAsynchronousOperationHandlers testingAsynchronousOperationHandlers;
    +
    +	private TestingAsynchronousOperationHandlers.TestingTriggerHandler testingTriggerHandler;
    +
    +	private TestingAsynchronousOperationHandlers.TestingStatusHandler testingStatusHandler;
    +
    +	private TestingGatewayRetriever<RestfulGateway> testingGatewayRetriever;
    +
    +	@Before
    +	public void setup() {
    +		testingGatewayRetriever = new TestingGatewayRetriever<>();
    +		testingAsynchronousOperationHandlers = new TestingAsynchronousOperationHandlers();
    +
    +		testingTriggerHandler = testingAsynchronousOperationHandlers.new TestingTriggerHandler(
    +			localRestAddress,
    +			testingGatewayRetriever,
    +			timeout,
    +			Collections.emptyMap(),
    +			TestingTriggerMessageHeaders.INSTANCE);
    +
    +		testingStatusHandler = testingAsynchronousOperationHandlers.new TestingStatusHandler(
    +			localRestAddress,
    +			testingGatewayRetriever,
    +			timeout,
    +			Collections.emptyMap(),
    +			TestingStatusMessageHeaders.INSTANCE);
    +	}
    +
    +	/**
    +	 * Tests the triggering and successful completion of an asynchronous operation.
    +	 */
    +	@Test
    +	public void testOperationCompletion() throws Exception {
    +		final CompletableFuture<String> savepointFuture = new CompletableFuture<>();
    +		final TestingRestfulGateway testingRestfulGateway = new TestingRestfulGateway.Builder()
    +			.setTriggerSavepointFunction((JobID jobId, String directory) -> savepointFuture)
    +			.build();
    +
    +		testingGatewayRetriever.setGateway(testingRestfulGateway);
    --- End diff --
    
    Sometimes you set the gateway in the test retriever, sometimes you don't (e.g., `testUnknownTriggerId`).
We don't rely on `testingGatewayRetriever` in the tests because `handleRequest` expects the
`RestfulGateway` as an argument.


---

Mime
View raw message