flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #5544: [FLINK-8645][configuration] Split classloader.parent-firs...
Date Wed, 21 Feb 2018 14:50:01 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5544
  
    Good change in principle, but I think "base" and "append" are not a great choice of names
for the parameters. Probably not very intuitive for users.
    
    How about calling them `default` and `additional`?
    
    While at it, should we also rename the `ALWAYS_PARENT_FIRST_LOADER` config key name? Calling
it `CLASS_LOADING_PARENT_FIRST_PACKAGES` or `CL_PARENT_FIRST_PATTERNS` seems better.


---

Mime
View raw message