flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GJL <...@git.apache.org>
Subject [GitHub] flink pull request #5509: [FLINK-7715][flip6] Port JarRunHandler to new REST...
Date Fri, 16 Feb 2018 14:21:09 GMT
Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5509#discussion_r168768024
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
    @@ -1126,7 +1126,7 @@ public static void setJobManagerAddressInConfig(Configuration config,
InetSocket
     	 * @return JobGraph extracted from the PackagedProgram
     	 * @throws ProgramInvocationException if the JobGraph generation failed
     	 */
    -	private static JobGraph createJobGraph(Configuration configuration, PackagedProgram
packagedProgram, int defaultParallelism) throws ProgramInvocationException {
    +	public static JobGraph createJobGraph(Configuration configuration, PackagedProgram packagedProgram,
int defaultParallelism) throws ProgramInvocationException {
    --- End diff --
    
    Maybe move method to utils class.


---

Mime
View raw message