flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StefanRRichter <...@git.apache.org>
Subject [GitHub] flink pull request #5423: [FLINK-8581] Improve performance for low latency n...
Date Fri, 16 Feb 2018 10:52:10 GMT
Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5423#discussion_r168725762
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGate.java
---
    @@ -72,7 +73,19 @@
     
     	void requestPartitions() throws IOException, InterruptedException;
     
    -	BufferOrEvent getNextBufferOrEvent() throws IOException, InterruptedException;
    +	/**
    +	 * Blocking call waiting for next {@link BufferOrEvent}.
    +	 *
    +	 * @return {@code Optional.empty()} if {@link #isFinished()} returns true.
    +	 */
    +	Optional<BufferOrEvent> getNextBufferOrEvent() throws IOException, InterruptedException;
    --- End diff --
    
    What do you think about this?


---

Mime
View raw message