flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeis2497052 <...@git.apache.org>
Subject [GitHub] flink issue #5497: Propose fixing some typos
Date Thu, 15 Feb 2018 21:42:06 GMT
Github user jeis2497052 commented on the issue:

    https://github.com/apache/flink/pull/5497
  
    Sorry about the space issue.  Shall I revert that doc?
    
    On Thu, Feb 15, 2018 at 4:27 PM Chesnay <notifications@github.com> wrote:
    
    > *@zentol* commented on this pull request.
    > ------------------------------
    >
    > In docs/dev/migration.md
    > <https://github.com/apache/flink/pull/5497#discussion_r168613102>:
    >
    > > @@ -145,16 +145,16 @@ public class BufferingSink implements SinkFunction<Tuple2<String,
Integer>>,
    >          bufferedElements.add(value);
    >          if (bufferedElements.size() == threshold) {
    >              for (Tuple2<String, Integer> element: bufferedElements) {
    > -	        // send it to the sink
    > -	    }
    > -	    bufferedElements.clear();
    > -	}
    > +            // send it to the sink
    > +        }
    > +        bufferedElements.clear();
    >
    > the indentation here doesn't look correct
    >
    > —
    > You are receiving this because you authored the thread.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/flink/pull/5497#pullrequestreview-97012008>,
    > or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/AetqJvwIYQgJBnE5RGNRNNzwlXVwQ3L-ks5tVKE_gaJpZM4SHVrl>
    > .
    >
    -- 
    John
    508.635.7384
    www.linkedin.com/in/johneismeier/



---

Mime
View raw message