flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StefanRRichter <...@git.apache.org>
Subject [GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery
Date Thu, 15 Feb 2018 14:50:23 GMT
Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5239#discussion_r168497476
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskLocalStateStore.java
---
    @@ -55,25 +54,24 @@
     	/** */
     	private final Map<Long, TaskStateSnapshot> storedTaskStateByCheckpointID;
     
    -	/** This is the base directory for all local state of the subtask that owns this {@link
TaskLocalStateStore}. */
    -	private final File subtaskLocalStateBaseDirectory;
    +	/** The root directories for all local state of this {@link TaskLocalStateStore}. */
    +	private final File[] localStateRootDirectories;
     
     	public TaskLocalStateStore(
     		JobID jobID,
     		JobVertexID jobVertexID,
     		int subtaskIndex,
    -		File localStateRootDir) {
    +		File[] localStateRootDirectories) {
     
     		this.jobID = jobID;
     		this.jobVertexID = jobVertexID;
     		this.subtaskIndex = subtaskIndex;
     		this.storedTaskStateByCheckpointID = new HashMap<>();
    -		this.subtaskLocalStateBaseDirectory =
    -			new File(localStateRootDir, createSubtaskPath(jobID, jobVertexID, subtaskIndex));
    +		this.localStateRootDirectories = localStateRootDirectories;
    --- End diff --
    
    Changed in later commit.


---

Mime
View raw message