flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StefanRRichter <...@git.apache.org>
Subject [GitHub] flink pull request #5423: [FLINK-8581] Improve performance for low latency n...
Date Tue, 13 Feb 2018 15:53:26 GMT
Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5423#discussion_r167596726
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
---
    @@ -131,9 +114,9 @@ public void release() {
     			}
     
     			// Release all available buffers
    -			Buffer buffer;
    -			while ((buffer = buffers.poll()) != null) {
    -				buffer.recycleBuffer();
    +			BufferConsumer bufferConsumer;
    +			while ((bufferConsumer = buffers.poll()) != null) {
    --- End diff --
    
    Maybe this part of the `release()`method should also go into the superclass, which usually
manages `buffers`. The method could also have an optional hook for additional cleanups inside
the `synchronized` block that subclasses can use if needed.


---

Mime
View raw message