flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #5438: [FLINK-8617][TableAPI & SQL] Fix code generation b...
Date Mon, 12 Feb 2018 09:46:09 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5438#discussion_r167503729
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala
---
    @@ -351,7 +351,7 @@ object ScalarOperators {
         else {
           s"""
             |${operand.code}
    -        |boolean $resultTerm = false;
    +        |boolean $resultTerm = ${operand.resultTerm} == null;
    --- End diff --
    
    This is not a bug but intended. The result type should be a primitive at this point. I
remove it and all tests are still working correctly.


---

Mime
View raw message