flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #5443: [FLINK-8626] Introduce BackPressureStatsTracker in...
Date Fri, 09 Feb 2018 16:01:24 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5443#discussion_r167267838
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
    @@ -143,7 +143,7 @@
     
     	private final StackTraceSampleCoordinator stackTraceSamples;
     
    -	private final BackPressureStatsTracker backPressureStatsTracker;
    +	private final BackPressureStatsTrackerImpl backPressureStatsTrackerImpl;
    --- End diff --
    
    this should be typed to the interface, and the variable name should not end in "Impl".


---

Mime
View raw message