flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GJL <...@git.apache.org>
Subject [GitHub] flink pull request #4809: [FLINK-7803][Documentation] Add missing savepoint ...
Date Mon, 05 Feb 2018 15:15:54 GMT
Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4809#discussion_r166001086
  
    --- Diff: docs/ops/state/savepoints.md ---
    @@ -120,6 +120,10 @@ This will atomically trigger a savepoint for the job with ID `:jobid`
and cancel
     
     If you don't specify a target directory, you need to have [configured a default directory](#configuration).
Otherwise, cancelling the job with a savepoint will fail.
     
    +<div class="alert alert-warning">
    --- End diff --
    
    Should be something like:
    ```
    <div class="alert alert-warning">
        <strong>Attention:</strong> <code>targetDirectory</code> has
to be a location accessible by both the JobManager(s) and TaskManager(s), e.g., a location
on a distributed file system.
    </div>
    ```
    because markdown is not rendered within HTML tags.
    
    Also, the *warning* you have added is currently in the *Cancel Job with Savepoint* section.
I think it should be moved to the section above (*Trigger a Savepoint*), or somewhere else
since it does not only apply to the cancelation case.
    
    @uce 


---

Mime
View raw message