flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GJL <...@git.apache.org>
Subject [GitHub] flink pull request #5397: [FLINK-7856][flip6] WIP JobVertexBackPressureHandl...
Date Fri, 02 Feb 2018 15:00:08 GMT
Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5397#discussion_r165666773
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TestingTaskExecutorGateway.java
---
    @@ -75,6 +76,17 @@ public void setDisconnectJobManagerConsumer(Consumer<Tuple2<JobID,
Throwable>> d
     		return CompletableFuture.completedFuture(Acknowledge.get());
     	}
     
    +	@Override
    +	public CompletableFuture<StackTraceSampleResponse> requestStackTraceSample(
    --- End diff --
    
    or maybe not


---

Mime
View raw message