flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #5172: [FLINK-8275] [Security] fix keytab local path in Y...
Date Fri, 02 Feb 2018 14:48:09 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5172#discussion_r165635517
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationMasterRunner.java
---
    @@ -170,9 +160,10 @@ protected int run(String[] args) {
     
     			final Configuration flinkConfig = createConfiguration(currDir, dynamicProperties);
     
    -			// set keytab principal and replace path with the local path of the shipped keytab
file in NodeManager
    -			if (keytabPath != null && remoteKeytabPrincipal != null) {
    -				flinkConfig.setString(SecurityOptions.KERBEROS_LOGIN_KEYTAB, keytabPath);
    +			File f = new File(currDir, Utils.KEYTAB_FILE_NAME);
    +			if (remoteKeytabPrincipal != null && f.exists()) {
    --- End diff --
    
    Can we re-add the debug log `LOG.debug("keytabPath: {}", keytabPath);` to provide more
visibility to this?


---

Mime
View raw message