flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink issue #5295: [FLINK-8384] [streaming] Session Window Assigner with Dyn...
Date Fri, 02 Feb 2018 10:30:01 GMT
Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/5295
  
    I think the changes are good! Thanks for working on this. 👍 
    
    As a final change before merging, I would annotate the new classes/methods as `@PublicEvolving`,
would you be ok with that? And I would also like to change `SessionWindowTimeGapExtractor.extract()`
to return a long instead of `Time`. What do you think?


---

Mime
View raw message