From issues-return-146536-archive-asf-public=cust-asf.ponee.io@flink.apache.org Mon Jan 8 10:43:26 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 4F13D180607 for ; Mon, 8 Jan 2018 10:43:26 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3F20B160C2C; Mon, 8 Jan 2018 09:43:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7E207160C1E for ; Mon, 8 Jan 2018 10:43:25 +0100 (CET) Received: (qmail 94159 invoked by uid 500); 8 Jan 2018 09:43:24 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 94146 invoked by uid 99); 8 Jan 2018 09:43:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jan 2018 09:43:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id AD379180643 for ; Mon, 8 Jan 2018 09:43:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.78 X-Spam-Level: X-Spam-Status: No, score=-3.78 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id L2Kz1YTXtsEh for ; Mon, 8 Jan 2018 09:43:22 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 81CBE5FB37 for ; Mon, 8 Jan 2018 09:43:22 +0000 (UTC) Received: (qmail 94104 invoked by uid 99); 8 Jan 2018 09:43:21 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jan 2018 09:43:21 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E7840DFC00; Mon, 8 Jan 2018 09:43:20 +0000 (UTC) From: NicoK To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org Message-ID: Subject: [GitHub] flink pull request #5251: [FLINK-8208][network-tests] Reduce mockito usage i... Content-Type: text/plain Date: Mon, 8 Jan 2018 09:43:20 +0000 (UTC) GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/5251 [FLINK-8208][network-tests] Reduce mockito usage in RecordWriterTest ## What is the purpose of the change Reduce mockito usage in `RecordWriterTest`. This PR is based on #5250. Please note: this is @pnowojski's commit taken out of #5105 which I have reviewed separately, so from my side, we're good to go. ## Brief change log - reduce mockito usage in `RecordWriterTest` ## Verifying this change This change is already covered by existing tests, since a test (tool) itself is changed. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): **no** - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no** - The serializers: **no** - The runtime per-record code paths (performance sensitive): **no** - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no** - The S3 file system connector: **no** ## Documentation - Does this pull request introduce a new feature? **no** - If yes, how is the feature documented? **not applicable** You can merge this pull request into a Git repository by running: $ git pull https://github.com/NicoK/flink flink-8208 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5251.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5251 ---- commit 82e3fa72af108c92a179ea441bf67e8b2e494d23 Author: Zhijiang Date: 2017-08-10T05:29:13Z [FLINK-7406][network] Implement Netty receiver incoming pipeline for credit-based commit 7c364f84df0969cc135c5a9835681c9d2d8e678a Author: Zhijiang Date: 2017-09-28T15:39:26Z [FLINK-7416][network] Implement Netty receiver outgoing pipeline for credit-based commit cfe85ced9a4c5bbc342e527d8b59e17ecf1cdad6 Author: Piotr Nowojski Date: 2017-12-18T14:26:20Z [hotfix][network] Drop redundant this reference usages commit 1c015dd3eebe7171606fa1d90045733eac2c6b75 Author: Piotr Nowojski Date: 2017-12-01T10:14:06Z [FLINK-8208][network-tests] Reduce mockito usage in RecordWriterTest commit 8101dc8f422a815bead8cedf92bd6a361d27ec44 Author: Piotr Nowojski Date: 2017-12-04T14:08:12Z [hotfix][network-tests] Simplify TestPooledBufferProvider commit dc5427696476d898da6ece19c7e05f6063ed98ae Author: Piotr Nowojski Date: 2017-12-04T14:13:57Z [FLINK-8207][network-tests] Unify TestInfiniteBufferProvider and TestPooledBufferProvider ---- ---