From issues-return-149981-archive-asf-public=cust-asf.ponee.io@flink.apache.org Mon Jan 29 17:52:03 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 9610C180654 for ; Mon, 29 Jan 2018 17:52:03 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 842F8160C31; Mon, 29 Jan 2018 16:52:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CBF1D160C2C for ; Mon, 29 Jan 2018 17:52:02 +0100 (CET) Received: (qmail 55888 invoked by uid 500); 29 Jan 2018 16:52:02 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 55878 invoked by uid 99); 29 Jan 2018 16:52:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Jan 2018 16:52:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 97E10CD160 for ; Mon, 29 Jan 2018 16:52:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id uve7HmoZCYxi for ; Mon, 29 Jan 2018 16:52:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E445E5FB41 for ; Mon, 29 Jan 2018 16:52:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7A1A3E0115 for ; Mon, 29 Jan 2018 16:52:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3AC0C21301 for ; Mon, 29 Jan 2018 16:52:00 +0000 (UTC) Date: Mon, 29 Jan 2018 16:52:00 +0000 (UTC) From: "Stefan Richter (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-8522) DefaultOperatorStateBackend writes data in checkpoint that is never read. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-8522?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1634= 3622#comment-16343622 ]=20 Stefan Richter commented on FLINK-8522: --------------------------------------- I don't think that we ever need to read the int, it was never read as far a= s I can see because=C2=A0the code already starts seeking to read positions.= That is why the int never had any effect, even if it was there but not con= sumed. But you should double check. > DefaultOperatorStateBackend writes data in checkpoint that is never read. > ------------------------------------------------------------------------- > > Key: FLINK-8522 > URL: https://issues.apache.org/jira/browse/FLINK-8522 > Project: Flink > Issue Type: Bug > Components: State Backends, Checkpointing > Affects Versions: 1.4.0 > Reporter: Kostas Kloudas > Assignee: Kostas Kloudas > Priority: Major > Fix For: 1.4.1 > > > In the DefaultOperatorStateBackend at line 283 we write in the checkpoint= an int declaring the number of the operator states that we include in the = checkpoint.=C2=A0 > This number is never read when restoring and this can lead to confusion a= nd problems with backwards compatibility and/or extension of the types of s= tate we=C2=A0support (e.g. broadcast state). > There are two easy solutions, either remove the line and do not=C2=A0writ= e the size, or make sure that we also read this number when restoring and s= imply ignore it. > I would go for the first one, i.e. remove the line. What do you think [~r= ichtesn] and [~tzulitai] ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)