From issues-return-149067-archive-asf-public=cust-asf.ponee.io@flink.apache.org Tue Jan 23 14:08:08 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 8BC1F180621 for ; Tue, 23 Jan 2018 14:08:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 7BA50160C39; Tue, 23 Jan 2018 13:08:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C1F92160C17 for ; Tue, 23 Jan 2018 14:08:07 +0100 (CET) Received: (qmail 42119 invoked by uid 500); 23 Jan 2018 13:08:06 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 42107 invoked by uid 99); 23 Jan 2018 13:08:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jan 2018 13:08:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 79FF2180336 for ; Tue, 23 Jan 2018 13:08:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -108.211 X-Spam-Level: X-Spam-Status: No, score=-108.211 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id PljoViEnxaBN for ; Tue, 23 Jan 2018 13:08:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 3DDB65FC75 for ; Tue, 23 Jan 2018 13:08:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 110F7E0F85 for ; Tue, 23 Jan 2018 13:08:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 00D7D25C6A for ; Tue, 23 Jan 2018 13:08:01 +0000 (UTC) Date: Tue, 23 Jan 2018 13:08:01 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-8493) Integrate queryable state with Flip-6 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-8493?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1633= 5755#comment-16335755 ]=20 ASF GitHub Bot commented on FLINK-8493: --------------------------------------- GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5339 [FLINK-8493] [flip6] Integrate queryable state with Flip-6 ## What is the purpose of the change =20 Adapt KvStateRegistry to accept multiple KvStateRegistryListeners. Intr= oduce the KvStateLocationOracle to retrieve the KvStateLocation. Adapt the Kv= StateClientProxy to accept multiple KvStateLocationOracles to retrieve the KvStateLocati= ons for different jobs. Registered the KvStateRegistryListener and KvStateLocat= ionOracle in TaskExecutor upon establishing a connection to the JobMaster. =20 ## Brief change log =20 - Introduce `KvStateLocationOracle` which you can ask for the `KvStateL= ocation` - Adapt `KvStateRegistry` to accept multiple `KvStateRegistryListener` - Adapt `KvStateClientProxy` to use `KvStateLocationOracle` instead of = `ActorGateway` - Register `JobMaster` as `KvStateLocationOracle` and `KvStateRegistryL= istener` when `TaskExecutor` establishes the connection to the `JobMaster` =20 ## Verifying this change =20 This change added tests and can be verified as follows: =20 - Added `KvStateClientProxyImplTest` and `KvStateRegistryTest` =20 ## Does this pull request potentially affect one of the following parts= : =20 - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(= Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its c= omponents), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) =20 ## Documentation =20 - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink flip6QS Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5339.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5339 =20 ---- commit 362145e44b79953136757276669e238e9c81d17f Author: Till Rohrmann Date: 2018-01-22T17:11:04Z [FLINK-8493] [flip6] Integrate queryable state with Flip-6 =20 Adapt KvStateRegistry to accept multiple KvStateRegistryListeners. Intr= oduce the KvStateLocationOracle to retrieve the KvStateLocation. Adapt the Kv= StateClientProxy to accept multiple KvStateLocationOracles to retrieve the KvStateLocati= ons for different jobs. Registered the KvStateRegistryListener and KvStateLocat= ionOracle in TaskExecutor upon establishing a connection to the JobMaster. ---- > Integrate queryable state with Flip-6 > ------------------------------------- > > Key: FLINK-8493 > URL: https://issues.apache.org/jira/browse/FLINK-8493 > Project: Flink > Issue Type: Improvement > Components: Distributed Coordination, Queryable State > Affects Versions: 1.5.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > In order to make Flip-6 support queryable state, we have to start and reg= ister the {{KvStateServer}}=C2=A0and {{KvStateProxyClient}} in the {{TaskEx= ecutor}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)