From issues-return-148613-archive-asf-public=cust-asf.ponee.io@flink.apache.org Fri Jan 19 16:38:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 6D73D180670 for ; Fri, 19 Jan 2018 16:38:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5D2EA160C27; Fri, 19 Jan 2018 15:38:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A7F74160C28 for ; Fri, 19 Jan 2018 16:38:05 +0100 (CET) Received: (qmail 51664 invoked by uid 500); 19 Jan 2018 15:38:04 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 51655 invoked by uid 99); 19 Jan 2018 15:38:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jan 2018 15:38:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 62647C1F35 for ; Fri, 19 Jan 2018 15:38:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.911 X-Spam-Level: X-Spam-Status: No, score=-99.911 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id E2Y09op90RdI for ; Fri, 19 Jan 2018 15:38:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 49DED5F473 for ; Fri, 19 Jan 2018 15:38:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2274BE0E0B for ; Fri, 19 Jan 2018 15:38:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7DFEF241C4 for ; Fri, 19 Jan 2018 15:38:01 +0000 (UTC) Date: Fri, 19 Jan 2018 15:38:01 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-8458) Add the switch for keeping both the old mode and the new credit-based mode MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-8458?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1633= 2411#comment-16332411 ]=20 ASF GitHub Bot commented on FLINK-8458: --------------------------------------- GitHub user zhijiangW opened a pull request: https://github.com/apache/flink/pull/5317 [FLINK-8458] Add the switch for keeping both the old mode and the new c= redit-based mode ## What is the purpose of the change =20 *After the whole feature of credit-based flow control is done, we shoul= d add a config parameter to switch on/off the new credit-based mode. To do = so, we can roll back to the old network mode for any expected risks.* =20 *The parameter is defined as taskmanager.network.credit-based-flow-cont= rol.enabled and the default value is true. This switch may be removed after= next release.* =20 *This PR is based on #4552 whose commit is also included for passing t= ravis.* =20 ## Brief change log =20 - *Abstract the `NetworkClientHandler` interface for different implem= entations in two modes* - *Abstract the `NetworkSequenceViewReader` interface for different i= mplementations in two modes* - *Define the `taskmanager.network.credit-based-flow-control.enabled`= in `TaskManagerOptions`* =20 ## Verifying this change =20 This change is already covered by existing tests*. =20 ## Does this pull request potentially affect one of the following parts= : =20 - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(= Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its c= omponents), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) =20 ## Documentation =20 - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) You can merge this pull request into a Git repository by running: $ git pull https://github.com/zhijiangW/flink FLINK-8458 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5317.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5317 =20 ---- commit a3b41f51173adaa382b42877142664d2b09101f7 Author: Zhijiang Date: 2017-09-30T06:36:19Z [FLINK-7456][network] Implement Netty sender incoming pipeline for cred= it-based commit a8154989f9c93e71e3051d7184c0f02316f1a3c7 Author: Zhijiang Date: 2018-01-17T06:15:04Z [FLINK-8458] Add the switch for keeping both the old mode and the new c= redit-based mode ---- > Add the switch for keeping both the old mode and the new credit-based mod= e > -------------------------------------------------------------------------= - > > Key: FLINK-8458 > URL: https://issues.apache.org/jira/browse/FLINK-8458 > Project: Flink > Issue Type: Sub-task > Components: Network > Reporter: zhijiang > Assignee: zhijiang > Priority: Major > Fix For: 1.5.0 > > > After the whole feature of credit-based flow control is done, we should a= dd a config parameter to switch on/off the new credit-based mode. To do so,= we can roll back to the old network mode for any expected risks. > The parameter is defined as {{taskmanager.network.credit-based-flow-contr= ol.enabled}}=C2=A0and the default value is true. This switch may be removed= after next release. -- This message was sent by Atlassian JIRA (v7.6.3#76005)