From issues-return-147192-archive-asf-public=cust-asf.ponee.io@flink.apache.org Wed Jan 10 10:22:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 8291D18062E for ; Wed, 10 Jan 2018 10:22:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 72B3C160C23; Wed, 10 Jan 2018 09:22:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B8228160C2E for ; Wed, 10 Jan 2018 10:22:05 +0100 (CET) Received: (qmail 95046 invoked by uid 500); 10 Jan 2018 09:22:04 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 95036 invoked by uid 99); 10 Jan 2018 09:22:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2018 09:22:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5531BC16CF for ; Wed, 10 Jan 2018 09:22:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.911 X-Spam-Level: X-Spam-Status: No, score=-99.911 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id OQF-XlESg0Ax for ; Wed, 10 Jan 2018 09:22:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 428FD5F39D for ; Wed, 10 Jan 2018 09:22:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B9D33E039B for ; Wed, 10 Jan 2018 09:22:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7A213274CE for ; Wed, 10 Jan 2018 09:22:02 +0000 (UTC) Date: Wed, 10 Jan 2018 09:22:02 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-8401) Allow subclass to override write-failure behavior in CassandraOutputFormat MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-8401?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1631= 9947#comment-16319947 ]=20 ASF GitHub Bot commented on FLINK-8401: --------------------------------------- GitHub user suez1224 opened a pull request: https://github.com/apache/flink/pull/5274 [FLINK-8401][Cassandra Connector]Refactor CassandraOutputFormat to allo= w subclass to customize the fai=E2=80=A6 ## What is the purpose of the change =20 Refactor CassandraOutputFormat to allow subclass to customize the failu= re handling logic. =20 =20 ## Brief change log - Added to protected methods for handling cassandra write result, the= se allow subclass to override them to customize. =20 =20 ## Verifying this change =20 This change is already covered by existing tests. =20 ## Does this pull request potentially affect one of the following parts= : =20 - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(= Evolving)`: ( no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its c= omponents), Checkpointing, Yarn/Mesos, ZooKeeper: ( no) - The S3 file system connector: (no) =20 ## Documentation =20 - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) You can merge this pull request into a Git repository by running: $ git pull https://github.com/suez1224/flink flink-8401 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5274.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5274 =20 ---- commit 8f6ae5636e549d7fe2f0788591acc8880c01af45 Author: Shuyi Chen Date: 2018-01-10T09:17:55Z Refactor CassandraOutputFormat to allow subclass to customize the failu= re handling logic ---- > Allow subclass to override write-failure behavior in CassandraOutputForma= t=20 > -------------------------------------------------------------------------= -- > > Key: FLINK-8401 > URL: https://issues.apache.org/jira/browse/FLINK-8401 > Project: Flink > Issue Type: Improvement > Components: Cassandra Connector > Reporter: Shuyi Chen > Assignee: Shuyi Chen > > Currently it will throw an exception and fail the entire job, we would li= ke to keep the current default behavior, but refactor the code to allow sub= class to override and customize the failure handling. -- This message was sent by Atlassian JIRA (v6.4.14#64029)