Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Tue, 2 Jan 2018 13:18:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13127960.1514890361000.555761.1514899080631@Atlassian.JIRA>
In-Reply-To: <JIRA.13127960.1514890361000@Atlassian.JIRA>
References: <JIRA.13127960.1514890361000@Atlassian.JIRA> <JIRA.13127960.1514890361969@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-8345) Iterate over keyed state on
 broadcast side of connect with broadcast.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 02 Jan 2018 13:18:08 -0000


    [ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308032#comment-16308032 ] 

ASF GitHub Bot commented on FLINK-8345:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5230#discussion_r159222186
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/SerializationProxiesTest.java ---
    @@ -287,16 +339,60 @@ public void testOperatorStateMetaInfoReadSerializerFailureResilience() throws Ex
     		PowerMockito.whenNew(TypeSerializerSerializationUtil.TypeSerializerSerializationProxy.class).withAnyArguments().thenReturn(mockProxy);
     
     		try (ByteArrayInputStreamWithPos in = new ByteArrayInputStreamWithPos(serialized)) {
    +			final DataInputViewStreamWrapper inWrapper = new DataInputViewStreamWrapper(in);
    +
     			metaInfo = OperatorBackendStateMetaInfoSnapshotReaderWriters
    -				.getReaderForVersion(OperatorBackendSerializationProxy.VERSION, Thread.currentThread().getContextClassLoader())
    --- End diff --
    
    The test below does it but why do you write it here as well?


> Iterate over keyed state on broadcast side of connect with broadcast.
> ---------------------------------------------------------------------
>
>                 Key: FLINK-8345
>                 URL: https://issues.apache.org/jira/browse/FLINK-8345
>             Project: Flink
>          Issue Type: New Feature
>          Components: Streaming
>    Affects Versions: 1.5.0
>            Reporter: Kostas Kloudas
>            Assignee: Kostas Kloudas
>             Fix For: 1.5.0
>
>


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)