From issues-return-149703-archive-asf-public=cust-asf.ponee.io@flink.apache.org Fri Jan 26 11:13:08 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 832CD180676 for ; Fri, 26 Jan 2018 11:13:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 731AE160C20; Fri, 26 Jan 2018 10:13:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B8CB2160C3E for ; Fri, 26 Jan 2018 11:13:07 +0100 (CET) Received: (qmail 37621 invoked by uid 500); 26 Jan 2018 10:13:06 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 37611 invoked by uid 99); 26 Jan 2018 10:13:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jan 2018 10:13:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 16379C15EE for ; Fri, 26 Jan 2018 10:13:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ooTYGC8ZyT7s for ; Fri, 26 Jan 2018 10:13:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 30E925FE31 for ; Fri, 26 Jan 2018 10:13:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C6B57E0D89 for ; Fri, 26 Jan 2018 10:13:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id E15B52476A for ; Fri, 26 Jan 2018 10:13:00 +0000 (UTC) Date: Fri, 26 Jan 2018 10:13:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-8344) Add support for HA to RestClusterClient MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340843#comment-16340843 ] ASF GitHub Bot commented on FLINK-8344: --------------------------------------- Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r164074612 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClientConfiguration.java --- @@ -19,60 +19,73 @@ package org.apache.flink.client.program.rest; import org.apache.flink.configuration.Configuration; -import org.apache.flink.configuration.JobManagerOptions; import org.apache.flink.configuration.RestOptions; import org.apache.flink.runtime.rest.RestClientConfiguration; import org.apache.flink.util.ConfigurationException; import org.apache.flink.util.Preconditions; +import static org.apache.flink.util.Preconditions.checkArgument; + /** * A configuration object for {@link RestClusterClient}s. */ public final class RestClusterClientConfiguration { - private final String blobServerAddress; - private final RestClientConfiguration restClientConfiguration; - private final String restServerAddress; + private final int awaitLeaderTimeout; + + private final int retryMaxAttempts; - private final int restServerPort; + private final int retryDelay; private RestClusterClientConfiguration( - String blobServerAddress, - RestClientConfiguration endpointConfiguration, - String restServerAddress, - int restServerPort) { - this.blobServerAddress = Preconditions.checkNotNull(blobServerAddress); + final RestClientConfiguration endpointConfiguration, + final int awaitLeaderTimeout, --- End diff -- changed all delays and timeouts to `long` > Add support for HA to RestClusterClient > --------------------------------------- > > Key: FLINK-8344 > URL: https://issues.apache.org/jira/browse/FLINK-8344 > Project: Flink > Issue Type: Improvement > Components: Client > Affects Versions: 1.5.0 > Reporter: Till Rohrmann > Assignee: Gary Yao > Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > The {{RestClusterClient}} must be able to deal with changing JobMasters in case of HA. We have to add functionality to reconnect to a newly elected leader in case of HA. -- This message was sent by Atlassian JIRA (v7.6.3#76005)