From issues-return-146131-archive-asf-public=cust-asf.ponee.io@flink.apache.org Thu Jan 4 17:58:09 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 91A2818077B for ; Thu, 4 Jan 2018 17:58:09 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 81CAE160C28; Thu, 4 Jan 2018 16:58:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C8095160C2B for ; Thu, 4 Jan 2018 17:58:08 +0100 (CET) Received: (qmail 76744 invoked by uid 500); 4 Jan 2018 16:58:08 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 76735 invoked by uid 99); 4 Jan 2018 16:58:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jan 2018 16:58:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 703FB180235 for ; Thu, 4 Jan 2018 16:58:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -108.011 X-Spam-Level: X-Spam-Status: No, score=-108.011 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id qZwujT3TMIi8 for ; Thu, 4 Jan 2018 16:58:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 525975F239 for ; Thu, 4 Jan 2018 16:58:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 92CACE05D7 for ; Thu, 4 Jan 2018 16:58:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 51C61240DA for ; Thu, 4 Jan 2018 16:58:00 +0000 (UTC) Date: Thu, 4 Jan 2018 16:58:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-8339) Let CustomCommandLine return a ClusterDescriptor MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-8339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311647#comment-16311647 ] ASF GitHub Bot commented on FLINK-8339: --------------------------------------- Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5225#discussion_r159702188 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java --- @@ -457,7 +499,19 @@ protected int stop(String[] args) throws Exception { final CustomCommandLine activeCommandLine = getActiveCustomCommandLine(commandLine); - final ClusterClient client = activeCommandLine.retrieveCluster(commandLine, configuration, configurationDirectory); + final ClusterDescriptor clusterDescriptor = activeCommandLine.createClusterDescriptor( --- End diff -- It seems that there is a pattern of getting the `clusterDescriptor` and and the `client` for all the commands. Also shutting down the client and closing the descriptor is repeated. Imo we should extract the pattern to avoid code duplication. > Let CustomCommandLine return a ClusterDescriptor > ------------------------------------------------ > > Key: FLINK-8339 > URL: https://issues.apache.org/jira/browse/FLINK-8339 > Project: Flink > Issue Type: Sub-task > Components: Client > Affects Versions: 1.5.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Labels: flip-6 > Fix For: 1.5.0 > > > The {{CustomCommandLine}} currently is able to retrieve a {{ClusterClient}} and deploy a cluster. In order to better separate concerns it would be good if the {{CustomCommandLine}} would simply return a {{ClusterDescriptor}} which could then be used to retrieve a {{ClusterClient}} or to deploy a Flink cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)