From issues-return-147339-archive-asf-public=cust-asf.ponee.io@flink.apache.org Wed Jan 10 17:05:05 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 421B718072F for ; Wed, 10 Jan 2018 17:05:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3223A160C23; Wed, 10 Jan 2018 16:05:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 770B3160C2E for ; Wed, 10 Jan 2018 17:05:04 +0100 (CET) Received: (qmail 37878 invoked by uid 500); 10 Jan 2018 16:05:03 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 37869 invoked by uid 99); 10 Jan 2018 16:05:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2018 16:05:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 206B3C137B for ; Wed, 10 Jan 2018 16:05:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.911 X-Spam-Level: X-Spam-Status: No, score=-99.911 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id E2TmbSXJlXKH for ; Wed, 10 Jan 2018 16:05:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 7922E5F398 for ; Wed, 10 Jan 2018 16:05:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 04F15E129D for ; Wed, 10 Jan 2018 16:05:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id AB4B7274D8 for ; Wed, 10 Jan 2018 16:05:00 +0000 (UTC) Date: Wed, 10 Jan 2018 16:05:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-8333) Split command options from deployment options in CliFrontend MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320502#comment-16320502 ] ASF GitHub Bot commented on FLINK-8333: --------------------------------------- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5220#discussion_r160721122 --- Diff: flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendStopTest.java --- @@ -99,6 +69,44 @@ public void testStop() throws Exception { } } + @Test(expected = CliArgsException.class) + public void testUnrecognizedOption() throws Exception { + // test unrecognized option + String[] parameters = { "-v", "-l" }; + CliFrontend testFrontend = new CliFrontend(CliFrontendTestUtils.getConfigDir()); + testFrontend.stop(parameters); + + fail("Should have failed."); + } + + @Test(expected = CliArgsException.class) + public void testMissingJobId() throws Exception { + // test missing job id + String[] parameters = {}; + CliFrontend testFrontend = new CliFrontend(CliFrontendTestUtils.getConfigDir()); + testFrontend.stop(parameters); + + fail("Should have failed."); + } + + @Test + public void testUnknownJobId() throws Exception { + // test unknown job Id + JobID jid = new JobID(); + + String[] parameters = { jid.toString() }; + StopTestCliFrontend testFrontend = new StopTestCliFrontend(true); + + try { + testFrontend.stop(parameters); + fail("Should have failed."); + } catch (IllegalArgumentException ignored) { + // expected + } + + Mockito.verify(testFrontend.client, times(1)).stop(any(JobID.class)); --- End diff -- True. Will adapt it accordingly. > Split command options from deployment options in CliFrontend > ------------------------------------------------------------ > > Key: FLINK-8333 > URL: https://issues.apache.org/jira/browse/FLINK-8333 > Project: Flink > Issue Type: Sub-task > Components: Client > Affects Versions: 1.5.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Labels: flip-6 > Fix For: 1.5.0 > > > In order to better support different {{CustomCommandLines}} we should split the command and deployment option parsing in the {{CliFrontend}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029)