From issues-return-147276-archive-asf-public=cust-asf.ponee.io@flink.apache.org Wed Jan 10 15:01:07 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 99AD718072F for ; Wed, 10 Jan 2018 15:01:07 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8A4A4160C2E; Wed, 10 Jan 2018 14:01:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D017C160C23 for ; Wed, 10 Jan 2018 15:01:06 +0100 (CET) Received: (qmail 42702 invoked by uid 500); 10 Jan 2018 14:01:06 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 42693 invoked by uid 99); 10 Jan 2018 14:01:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2018 14:01:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7753EC24ED for ; Wed, 10 Jan 2018 14:01:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.711 X-Spam-Level: X-Spam-Status: No, score=-100.711 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id loQfKLk2rHSe for ; Wed, 10 Jan 2018 14:01:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1700C5F343 for ; Wed, 10 Jan 2018 14:01:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 60AABE0F23 for ; Wed, 10 Jan 2018 14:01:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 16587274D1 for ; Wed, 10 Jan 2018 14:01:00 +0000 (UTC) Date: Wed, 10 Jan 2018 14:01:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-8329) Move YarnClient out of YarnClusterClient MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320279#comment-16320279 ] ASF GitHub Bot commented on FLINK-8329: --------------------------------------- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5216#discussion_r160684153 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -143,31 +138,48 @@ private YarnConfigOptions.UserJarInclusion userJarInclusion; public AbstractYarnClusterDescriptor( - org.apache.flink.configuration.Configuration flinkConfiguration, - String configurationDirectory) { + Configuration flinkConfiguration, + String configurationDirectory, + YarnClient yarnClient) { + + yarnConfiguration = new YarnConfiguration(); + // for unit tests only if (System.getenv("IN_TESTS") != null) { try { - conf.addResource(new File(System.getenv("YARN_CONF_DIR") + "/yarn-site.xml").toURI().toURL()); + yarnConfiguration.addResource(new File(System.getenv("YARN_CONF_DIR") + "/yarn-site.xml").toURI().toURL()); --- End diff -- True, will change it. > Move YarnClient out of YarnClusterClient > ---------------------------------------- > > Key: FLINK-8329 > URL: https://issues.apache.org/jira/browse/FLINK-8329 > Project: Flink > Issue Type: Sub-task > Components: Client > Affects Versions: 1.5.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Labels: flip-6 > Fix For: 1.5.0 > > > Move the {{YarnClient}} from the {{YarnClusterClient}} to the {{AbstractYarnClusterDescriptor}} which will be responsible for the lifecycle management of the {{YarnClient}}. This change is a clean up task which will better structure the client code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)