From issues-return-146871-archive-asf-public=cust-asf.ponee.io@flink.apache.org Mon Jan 8 23:27:05 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 01ACD180607 for ; Mon, 8 Jan 2018 23:27:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E5ABF160C2C; Mon, 8 Jan 2018 22:27:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 358C3160C29 for ; Mon, 8 Jan 2018 23:27:04 +0100 (CET) Received: (qmail 44346 invoked by uid 500); 8 Jan 2018 22:27:03 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 44337 invoked by uid 99); 8 Jan 2018 22:27:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jan 2018 22:27:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id F108C1A0314 for ; Mon, 8 Jan 2018 22:27:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.911 X-Spam-Level: X-Spam-Status: No, score=-99.911 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id YpB5luhOwATu for ; Mon, 8 Jan 2018 22:27:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0B34A5F22E for ; Mon, 8 Jan 2018 22:27:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9ADF4E0AFC for ; Mon, 8 Jan 2018 22:27:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 53586240DE for ; Mon, 8 Jan 2018 22:27:01 +0000 (UTC) Date: Mon, 8 Jan 2018 22:27:01 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317218#comment-16317218 ] ASF GitHub Bot commented on FLINK-8325: --------------------------------------- Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160250423 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -121,7 +121,7 @@ class AggregationCodeGenerator( // get parameter lists for aggregation functions val parametersCode = aggFields.map { inFields => - val fields = inFields.map { f => + val fields = inFields.filter(index => index > -1).map { f => --- End diff -- remove double space > Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1) > ------------------------------------------------------------------ > > Key: FLINK-8325 > URL: https://issues.apache.org/jira/browse/FLINK-8325 > Project: Flink > Issue Type: Bug > Components: Table API & SQL > Affects Versions: 1.5.0 > Reporter: sunjincheng > Assignee: sunjincheng > > COUNT(1) with Group Window, always output 0. > e.g. > DATA: > {code} > val data = List( > (1L, 1, "Hi"), > (2L, 2, "Hello"), > (4L, 2, "Hello"), > (8L, 3, "Hello world"), > (16L, 3, "Hello world")) > {code} > SQL: > {code} > SELECT b, COUNT(1) FROM MyTable GROUP BY Hop(proctime, interval '0.001' SECOND, interval '0.002' SECOND),b > {code} > OUTPUT: > {code} > 1,0,1, > 1,0,1, > 2,0,1, > 2,0,1, > 2,0,2, > 3,0,1, > 3,0,1 > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)