Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 7D560180630 for ; Tue, 2 Jan 2018 16:29:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6CAE6160C39; Tue, 2 Jan 2018 15:29:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AFA71160C26 for ; Tue, 2 Jan 2018 16:29:04 +0100 (CET) Received: (qmail 44550 invoked by uid 500); 2 Jan 2018 15:29:03 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 44440 invoked by uid 99); 2 Jan 2018 15:29:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jan 2018 15:29:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CDA64C23EA for ; Tue, 2 Jan 2018 15:29:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.011 X-Spam-Level: X-Spam-Status: No, score=-100.011 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 3b4F-0brQUKo for ; Tue, 2 Jan 2018 15:29:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id EB2EC5FB94 for ; Tue, 2 Jan 2018 15:29:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1831FE126D for ; Tue, 2 Jan 2018 15:29:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6B07024102 for ; Tue, 2 Jan 2018 15:29:00 +0000 (UTC) Date: Tue, 2 Jan 2018 15:29:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-8257) Unify the value checks for setParallelism() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 02 Jan 2018 15:29:05 -0000 [ https://issues.apache.org/jira/browse/FLINK-8257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308219#comment-16308219 ] ASF GitHub Bot commented on FLINK-8257: --------------------------------------- Github user xccui closed the pull request at: https://github.com/apache/flink/pull/5192 > Unify the value checks for setParallelism() > ------------------------------------------- > > Key: FLINK-8257 > URL: https://issues.apache.org/jira/browse/FLINK-8257 > Project: Flink > Issue Type: Improvement > Components: Configuration > Reporter: Xingcan Cui > Assignee: Xingcan Cui > Fix For: 1.5.0 > > > The {{setParallelism()}} method exist in many components from different levels. Some of the methods require the input value to be greater than {{1}} (e.g., {{StreamTransformation.setParallelism()}}), while some of them also allow the value to be {{ExecutionConfig.PARALLELISM_DEFAULT}}, which is {{-1}} by default (e.g., {{DataSink.setParallelism()}}). We need to unify the value checks for these methods. -- This message was sent by Atlassian JIRA (v6.4.14#64029)