From issues-return-149243-archive-asf-public=cust-asf.ponee.io@flink.apache.org Wed Jan 24 12:13:03 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id E9B4F180676 for ; Wed, 24 Jan 2018 12:13:03 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D9673160C2E; Wed, 24 Jan 2018 11:13:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 28C18160C3C for ; Wed, 24 Jan 2018 12:13:03 +0100 (CET) Received: (qmail 48412 invoked by uid 500); 24 Jan 2018 11:13:02 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 48403 invoked by uid 99); 24 Jan 2018 11:13:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Jan 2018 11:13:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id CC828180710 for ; Wed, 24 Jan 2018 11:13:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -108.711 X-Spam-Level: X-Spam-Status: No, score=-108.711 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id pSfeQzag2DVr for ; Wed, 24 Jan 2018 11:13:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B1A2D5FAC9 for ; Wed, 24 Jan 2018 11:13:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5BB38E0F66 for ; Wed, 24 Jan 2018 11:13:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 140E7240F2 for ; Wed, 24 Jan 2018 11:13:00 +0000 (UTC) Date: Wed, 24 Jan 2018 11:13:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-8242) ClassCastException in OrcTableSource.toOrcPredicate MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337413#comment-16337413 ] ASF GitHub Bot commented on FLINK-8242: --------------------------------------- Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5345#discussion_r163517596 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/RexProgramExtractor.scala --- @@ -214,6 +213,10 @@ class RexNodeToExpressionConverter( // convert to BigDecimal literal.getValueAs(classOf[java.math.BigDecimal]) + case _ if literal.getValue.isInstanceOf[NlsString] => --- End diff -- This should not be necessary because it is already done line 204. All tests are still working if I remove this change. > ClassCastException in OrcTableSource.toOrcPredicate > --------------------------------------------------- > > Key: FLINK-8242 > URL: https://issues.apache.org/jira/browse/FLINK-8242 > Project: Flink > Issue Type: Bug > Components: Batch Connectors and Input/Output Formats > Affects Versions: 1.4.0 > Reporter: Fabian Hueske > Assignee: Fabian Hueske > Priority: Critical > Fix For: 1.5.0, 1.4.1 > > > The {{OrcTableSource}} tries to cast all predicate literals to {{Serializable}} in its {{toOrcPredicate()}} method. This fails with a {{ClassCastException}} if a literal is not serializable. > Instead of failing, we should ignore the predicate and log a WARN message. -- This message was sent by Atlassian JIRA (v7.6.3#76005)