From issues-return-146532-archive-asf-public=cust-asf.ponee.io@flink.apache.org Mon Jan 8 09:19:09 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 2C6D6180607 for ; Mon, 8 Jan 2018 09:19:09 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 187A4160C2C; Mon, 8 Jan 2018 08:19:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 61407160C1E for ; Mon, 8 Jan 2018 09:19:08 +0100 (CET) Received: (qmail 34043 invoked by uid 500); 8 Jan 2018 08:19:07 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 34034 invoked by uid 99); 8 Jan 2018 08:19:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jan 2018 08:19:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1590E1A06EF for ; Mon, 8 Jan 2018 08:19:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.911 X-Spam-Level: X-Spam-Status: No, score=-99.911 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id MRt2SUkynOrW for ; Mon, 8 Jan 2018 08:19:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 003A05FAC9 for ; Mon, 8 Jan 2018 08:19:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 72CF6E0352 for ; Mon, 8 Jan 2018 08:19:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 235C2212F8 for ; Mon, 8 Jan 2018 08:19:01 +0000 (UTC) Date: Mon, 8 Jan 2018 08:19:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-8207) Unify TestPooledBufferProvider and TestInfinityBufferProvider MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315854#comment-16315854 ] ASF GitHub Bot commented on FLINK-8207: --------------------------------------- GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/5250 [FLINK-8207][network-tests] Unify TestInfiniteBufferProvider and TestPooledBufferProvider ## What is the purpose of the change `TestPooledBufferProvider` and `TestInfiniteBufferProvider` share a low of code and could be unified into a single class for simplicity. This PR is based on #4533. ## Brief change log - merge `TestInfinityBufferProvider` functionality into `TestPooledBufferProvider` ## Verifying this change This change is already covered by existing tests, since we are changing a test utility. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): **no** - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no** - The serializers: **no** - The runtime per-record code paths (performance sensitive): **no** - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no** - The S3 file system connector: **no** ## Documentation - Does this pull request introduce a new feature? **no** - If yes, how is the feature documented? **not applicable** You can merge this pull request into a Git repository by running: $ git pull https://github.com/NicoK/flink flink-8207 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5250.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5250 ---- commit 82e3fa72af108c92a179ea441bf67e8b2e494d23 Author: Zhijiang Date: 2017-08-10T05:29:13Z [FLINK-7406][network] Implement Netty receiver incoming pipeline for credit-based commit 7c364f84df0969cc135c5a9835681c9d2d8e678a Author: Zhijiang Date: 2017-09-28T15:39:26Z [FLINK-7416][network] Implement Netty receiver outgoing pipeline for credit-based commit cfe85ced9a4c5bbc342e527d8b59e17ecf1cdad6 Author: Piotr Nowojski Date: 2017-12-18T14:26:20Z [hotfix][network] Drop redundant this reference usages commit dc5427696476d898da6ece19c7e05f6063ed98ae Author: Piotr Nowojski Date: 2017-12-04T14:13:57Z [FLINK-8207][network-tests] Unify TestInfiniteBufferProvider and TestPooledBufferProvider ---- > Unify TestPooledBufferProvider and TestInfinityBufferProvider > ------------------------------------------------------------- > > Key: FLINK-8207 > URL: https://issues.apache.org/jira/browse/FLINK-8207 > Project: Flink > Issue Type: Sub-task > Components: Network > Reporter: Piotr Nowojski > Assignee: Piotr Nowojski > Fix For: 1.5.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)