From issues-return-150108-archive-asf-public=cust-asf.ponee.io@flink.apache.org Tue Jan 30 15:19:02 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id DE9C518061A for ; Tue, 30 Jan 2018 15:19:02 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CE632160C53; Tue, 30 Jan 2018 14:19:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 18022160C42 for ; Tue, 30 Jan 2018 15:19:01 +0100 (CET) Received: (qmail 40090 invoked by uid 500); 30 Jan 2018 14:19:01 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 40081 invoked by uid 99); 30 Jan 2018 14:19:01 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Jan 2018 14:19:01 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 293F4E0A04; Tue, 30 Jan 2018 14:19:01 +0000 (UTC) From: tillrohrmann To: issues@flink.apache.org Reply-To: issues@flink.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #5383: [hotfix][kafka-tests] Do not hide original excepti... Content-Type: text/plain Message-Id: <20180130141901.293F4E0A04@git1-us-west.apache.org> Date: Tue, 30 Jan 2018 14:19:01 +0000 (UTC) Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5383#discussion_r164754175 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011ITCase.java --- @@ -592,24 +595,21 @@ private Properties createProperties() { return properties; } - private void assertIsCausedBy(Class clazz, Throwable ex) { + private static Optional isCausedBy(Class clazz, Throwable ex) { --- End diff -- Better to use `ExceptionUtils#findThrowable`. ---