From issues-return-149837-archive-asf-public=cust-asf.ponee.io@flink.apache.org  Sat Jan 27 09:23:18 2018
Return-Path: <issues-return-149837-archive-asf-public=cust-asf.ponee.io@flink.apache.org>
X-Original-To: archive-asf-public@eu.ponee.io
Delivered-To: archive-asf-public@eu.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by mx-eu-01.ponee.io (Postfix) with ESMTP id 28CA418079A
	for <archive-asf-public@eu.ponee.io>; Sat, 27 Jan 2018 09:23:18 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 11CBB160C51; Sat, 27 Jan 2018 08:23:18 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 44F17160C52
	for <archive-asf-public@cust-asf.ponee.io>; Sat, 27 Jan 2018 09:23:17 +0100 (CET)
Received: (qmail 51273 invoked by uid 500); 27 Jan 2018 08:23:16 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 51020 invoked by uid 99); 27 Jan 2018 08:23:16 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Jan 2018 08:23:16 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 20B0CF17DA; Sat, 27 Jan 2018 08:23:16 +0000 (UTC)
From: hequn8128 <git@git.apache.org>
To: issues@flink.apache.org
Reply-To: issues@flink.apache.org
References: <git-pr-5367-flink@git.apache.org>
In-Reply-To: <git-pr-5367-flink@git.apache.org>
Subject: [GitHub] flink pull request #5367: [FLINK-7923][Table API & SQL] Support field access...
Content-Type: text/plain
Message-Id: <20180127082316.20B0CF17DA@git1-us-west.apache.org>
Date: Sat, 27 Jan 2018 08:23:16 +0000 (UTC)

Github user hequn8128 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5367#discussion_r164266896
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala ---
    @@ -984,6 +987,63 @@ object ScalarOperators {
         }
       }
     
    +  def generateDot(codeGenerator: CodeGenerator,
    --- End diff --
    
    Arguments of the method should be indented. 


---