From issues-return-148491-archive-asf-public=cust-asf.ponee.io@flink.apache.org Fri Jan 19 03:35:40 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id A9322180654 for ; Fri, 19 Jan 2018 03:35:40 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 98FC2160C48; Fri, 19 Jan 2018 02:35:40 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DFF66160C26 for ; Fri, 19 Jan 2018 03:35:39 +0100 (CET) Received: (qmail 2530 invoked by uid 500); 19 Jan 2018 02:35:39 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 2520 invoked by uid 99); 19 Jan 2018 02:35:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jan 2018 02:35:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A690BC2A2E for ; Fri, 19 Jan 2018 02:35:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.03 X-Spam-Level: X-Spam-Status: No, score=-4.03 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id RcjtnvmvsDym for ; Fri, 19 Jan 2018 02:35:36 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id B73CC5F3DF for ; Fri, 19 Jan 2018 02:35:35 +0000 (UTC) Received: (qmail 2490 invoked by uid 99); 19 Jan 2018 02:35:34 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jan 2018 02:35:34 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D4EEDDFFCF; Fri, 19 Jan 2018 02:35:34 +0000 (UTC) From: eastcirclek To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #5307: [FLINK-8431] [mesos] Allow to specify # GPUs for T... Content-Type: text/plain Message-Id: <20180119023534.D4EEDDFFCF@git1-us-west.apache.org> Date: Fri, 19 Jan 2018 02:35:34 +0000 (UTC) Github user eastcirclek commented on a diff in the pull request: https://github.com/apache/flink/pull/5307#discussion_r162525499 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java --- @@ -238,6 +254,16 @@ public static MesosTaskManagerParameters create(Configuration flinkConfig) { cpus = Math.max(containeredParameters.numSlots(), 1.0); } + double gpus = flinkConfig.getDouble(MESOS_RM_TASKS_GPUS, 0.0); + if (gpus < 0) { + throw new IllegalConfigurationException(MESOS_RM_TASKS_GPUS.key() + + " cannot be negative"); + } + if (gpus % 1 != 0) { --- End diff -- We'd better be on the safe side as you said. ---