From issues-return-148212-archive-asf-public=cust-asf.ponee.io@flink.apache.org Tue Jan 16 08:22:24 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 439CF18065B for ; Tue, 16 Jan 2018 08:22:24 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 32231160C34; Tue, 16 Jan 2018 07:22:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7775F160C26 for ; Tue, 16 Jan 2018 08:22:23 +0100 (CET) Received: (qmail 3951 invoked by uid 500); 16 Jan 2018 07:22:22 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 3941 invoked by uid 99); 16 Jan 2018 07:22:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jan 2018 07:22:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E31A9C19BF for ; Tue, 16 Jan 2018 07:22:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.029 X-Spam-Level: X-Spam-Status: No, score=-4.029 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id NuBEEfScNqpw for ; Tue, 16 Jan 2018 07:22:21 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 158EE5F33D for ; Tue, 16 Jan 2018 07:22:20 +0000 (UTC) Received: (qmail 3915 invoked by uid 99); 16 Jan 2018 07:22:20 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jan 2018 07:22:20 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 8A519DFCFA; Tue, 16 Jan 2018 07:22:20 +0000 (UTC) From: zhijiangW To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink issue #4552: [FLINK-7456][network] Implement Netty sender incoming pip... Content-Type: text/plain Message-Id: <20180116072220.8A519DFCFA@git1-us-west.apache.org> Date: Tue, 16 Jan 2018 07:22:20 +0000 (UTC) Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4552 @NicoK , thanks for your reviews! I have submitted all the patches you provided offline to address above issues. 1. Remove `FLINK-8425` from this PR. 2. Do you think I should add more tests for `nextBufferIsEvent`? Because I already verified that in previous related tests 3. For adding the switch issue, I found some difficulties to leave messages for you offline. We can further confirm that. ---