From issues-return-148110-archive-asf-public=cust-asf.ponee.io@flink.apache.org Mon Jan 15 13:30:23 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id C90E3180657 for ; Mon, 15 Jan 2018 13:30:23 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B90C7160C31; Mon, 15 Jan 2018 12:30:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0BDCE160C25 for ; Mon, 15 Jan 2018 13:30:22 +0100 (CET) Received: (qmail 61580 invoked by uid 500); 15 Jan 2018 12:30:22 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 61571 invoked by uid 99); 15 Jan 2018 12:30:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Jan 2018 12:30:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CDDFEC1754 for ; Mon, 15 Jan 2018 12:30:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.03 X-Spam-Level: X-Spam-Status: No, score=-4.03 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id LluQh-e9bmwh for ; Mon, 15 Jan 2018 12:30:21 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 0F3005FAC9 for ; Mon, 15 Jan 2018 12:30:19 +0000 (UTC) Received: (qmail 61244 invoked by uid 99); 15 Jan 2018 12:30:19 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Jan 2018 12:30:19 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 83506DFCFA; Mon, 15 Jan 2018 12:30:16 +0000 (UTC) From: sunjincheng121 To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #4117: [FLINK-6813][table]Add TIMESTAMPDIFF supported in ... Content-Type: text/plain Message-Id: <20180115123017.83506DFCFA@git1-us-west.apache.org> Date: Mon, 15 Jan 2018 12:30:16 +0000 (UTC) Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4117#discussion_r161504809 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala --- @@ -702,12 +703,15 @@ object ScalarOperators { def generateTemporalPlusMinus( plus: Boolean, nullCheck: Boolean, + typeName: SqlTypeName, left: GeneratedExpression, right: GeneratedExpression) : GeneratedExpression = { val op = if (plus) "+" else "-" + val AVGDAYS_PRE_MONTH = 30.5 --- End diff -- Is not a standard, I did not find the relevant norms, do you have any suggestions? ---