From issues-return-147638-archive-asf-public=cust-asf.ponee.io@flink.apache.org Thu Jan 11 16:11:19 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id E235F180656 for ; Thu, 11 Jan 2018 16:11:19 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D2856160C41; Thu, 11 Jan 2018 15:11:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2428A160C1F for ; Thu, 11 Jan 2018 16:11:18 +0100 (CET) Received: (qmail 60348 invoked by uid 500); 11 Jan 2018 15:11:18 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 60321 invoked by uid 99); 11 Jan 2018 15:11:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jan 2018 15:11:18 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D4FCDC0083 for ; Thu, 11 Jan 2018 15:11:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.03 X-Spam-Level: X-Spam-Status: No, score=-4.03 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id yKdk3_O-swpA for ; Thu, 11 Jan 2018 15:11:17 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 8E8715F30C for ; Thu, 11 Jan 2018 15:11:16 +0000 (UTC) Received: (qmail 59292 invoked by uid 99); 11 Jan 2018 15:11:15 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jan 2018 15:11:15 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 757BBE5E08; Thu, 11 Jan 2018 15:11:15 +0000 (UTC) From: tillrohrmann To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #5225: [FLINK-8339] [flip6] Let CustomCommandLine return ... Content-Type: text/plain Message-Id: <20180111151115.757BBE5E08@git1-us-west.apache.org> Date: Thu, 11 Jan 2018 15:11:15 +0000 (UTC) Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5225#discussion_r160985701 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java --- @@ -457,7 +499,19 @@ protected int stop(String[] args) throws Exception { final CustomCommandLine activeCommandLine = getActiveCustomCommandLine(commandLine); - final ClusterClient client = activeCommandLine.retrieveCluster(commandLine, configuration, configurationDirectory); + final ClusterDescriptor clusterDescriptor = activeCommandLine.createClusterDescriptor( --- End diff -- You're right. I would like to postpone addressing this issue until we've introduce the typed cluster id. Otherwise I fear that it would inflict quite some merge conflicts. ---