From issues-return-147620-archive-asf-public=cust-asf.ponee.io@flink.apache.org Thu Jan 11 15:26:28 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 7593E180656 for ; Thu, 11 Jan 2018 15:26:28 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6611E160C20; Thu, 11 Jan 2018 14:26:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A9A88160C41 for ; Thu, 11 Jan 2018 15:26:27 +0100 (CET) Received: (qmail 52402 invoked by uid 500); 11 Jan 2018 14:26:26 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 52386 invoked by uid 99); 11 Jan 2018 14:26:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jan 2018 14:26:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 81A6D1A0669 for ; Thu, 11 Jan 2018 14:26:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.03 X-Spam-Level: X-Spam-Status: No, score=-4.03 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id I1-R81BQuriR for ; Thu, 11 Jan 2018 14:26:23 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id EF18B5FC12 for ; Thu, 11 Jan 2018 14:26:22 +0000 (UTC) Received: (qmail 49928 invoked by uid 99); 11 Jan 2018 14:26:21 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jan 2018 14:26:21 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4589BF32D7; Thu, 11 Jan 2018 14:26:20 +0000 (UTC) From: pnowojski To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery Content-Type: text/plain Message-Id: <20180111142620.4589BF32D7@git1-us-west.apache.org> Date: Thu, 11 Jan 2018 14:26:20 +0000 (UTC) Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r160913576 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskStateManagerImpl.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.state; + +import org.apache.flink.api.common.JobID; +import org.apache.flink.runtime.checkpoint.CheckpointMetaData; +import org.apache.flink.runtime.checkpoint.CheckpointMetrics; +import org.apache.flink.runtime.checkpoint.JobManagerTaskRestore; +import org.apache.flink.runtime.checkpoint.OperatorSubtaskState; +import org.apache.flink.runtime.checkpoint.TaskStateSnapshot; +import org.apache.flink.runtime.executiongraph.ExecutionAttemptID; +import org.apache.flink.runtime.jobgraph.OperatorID; +import org.apache.flink.runtime.taskmanager.CheckpointResponder; + +import javax.annotation.Nonnull; +import javax.annotation.Nullable; + +/** + * This class is the default implementation of {@link TaskStateManager} and collaborates with the job manager + * through {@link CheckpointResponder}) as well as a task-manager-local state store. Like this, client code does + * not have to deal with the differences between remote or local state on recovery because this class handles both + * cases transparently. + * + * Reported state is tagged by clients so that this class can properly forward to the right receiver for the + * checkpointed state. + * + * TODO: all interaction with local state store must still be implemented! It is currently just a placeholder. + */ +public class TaskStateManagerImpl implements TaskStateManager { + + /** The id of the job for which this manager was created, can report, and recover. */ + private final JobID jobId; + + /** The execution attempt id that this manager reports for. */ + private final ExecutionAttemptID executionAttemptID; + + /** The data given by the job manager to restore the job. This is not set for a new job without previous state. */ + private final JobManagerTaskRestore jobManagerTaskRestore; + + /** The local state store to which this manager reports local state snapshots. */ + private final TaskLocalStateStore localStateStore; + + /** The checkpoint responder through which this manager can report to the job manager. */ + private final CheckpointResponder checkpointResponder; + + public TaskStateManagerImpl( + JobID jobId, + ExecutionAttemptID executionAttemptID, + TaskLocalStateStore localStateStore, + JobManagerTaskRestore jobManagerTaskRestore, + CheckpointResponder checkpointResponder) { + + this.jobId = jobId; + this.localStateStore = localStateStore; --- End diff -- can you add `checkNotNulls` on the parameters? Or use `Optional<>` or mark them `@Nullable` accordingly? ---