From issues-return-147347-archive-asf-public=cust-asf.ponee.io@flink.apache.org Wed Jan 10 17:15:51 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 9C39118076D for ; Wed, 10 Jan 2018 17:15:51 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 876A1160C23; Wed, 10 Jan 2018 16:15:51 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D2429160C2E for ; Wed, 10 Jan 2018 17:15:50 +0100 (CET) Received: (qmail 70883 invoked by uid 500); 10 Jan 2018 16:15:50 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 70873 invoked by uid 99); 10 Jan 2018 16:15:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2018 16:15:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9FC41C17EB for ; Wed, 10 Jan 2018 16:15:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.03 X-Spam-Level: X-Spam-Status: No, score=-4.03 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id X34gt6yuBhxG for ; Wed, 10 Jan 2018 16:15:49 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 9822B5F2C4 for ; Wed, 10 Jan 2018 16:15:48 +0000 (UTC) Received: (qmail 70701 invoked by uid 99); 10 Jan 2018 16:15:48 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2018 16:15:48 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1B4F8DFDE6; Wed, 10 Jan 2018 16:15:48 +0000 (UTC) From: NicoK To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom... Content-Type: text/plain Message-Id: <20180110161548.1B4F8DFDE6@git1-us-west.apache.org> Date: Wed, 10 Jan 2018 16:15:48 +0000 (UTC) Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r160695373 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java --- @@ -98,20 +135,35 @@ public void close() { } } + /** + * Adds to maintain the unannounced credits from the consumer and it may trigger + * enqueue the corresponding reader for this consumer transferring data. + * + * @param receiverId The input channel id to identify consumer. + * @param credit The unannounced credits of the consumer. + */ + public void addCredit(InputChannelID receiverId, int credit) throws Exception { --- End diff -- could be `package-private` ---