From issues-return-147238-archive-asf-public=cust-asf.ponee.io@flink.apache.org Wed Jan 10 14:21:27 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 3E6EE18072F for ; Wed, 10 Jan 2018 14:21:27 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 2E745160C2E; Wed, 10 Jan 2018 13:21:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 72FC5160C23 for ; Wed, 10 Jan 2018 14:21:26 +0100 (CET) Received: (qmail 54563 invoked by uid 500); 10 Jan 2018 13:21:25 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 54554 invoked by uid 99); 10 Jan 2018 13:21:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2018 13:21:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 27DD21805C7 for ; Wed, 10 Jan 2018 13:21:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.03 X-Spam-Level: X-Spam-Status: No, score=-4.03 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id kOBE8dTA31kj for ; Wed, 10 Jan 2018 13:21:24 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id F06485F3D0 for ; Wed, 10 Jan 2018 13:21:23 +0000 (UTC) Received: (qmail 54530 invoked by uid 99); 10 Jan 2018 13:21:23 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2018 13:21:23 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 6A5C0DFB0D; Wed, 10 Jan 2018 13:21:23 +0000 (UTC) From: tillrohrmann To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #5215: [FLINK-8328] [flip6] Move Yarn ApplicationStatus p... Content-Type: text/plain Message-Id: <20180110132123.6A5C0DFB0D@git1-us-west.apache.org> Date: Wed, 10 Jan 2018 13:21:23 +0000 (UTC) Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5215#discussion_r160674117 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java --- @@ -660,7 +570,25 @@ public int run( "yarn application -kill " + applicationId.getOpt()); yarnCluster.disconnect(); } else { - runInteractiveCli(yarnCluster, true); + ScheduledThreadPoolExecutor scheduledExecutorService = new ScheduledThreadPoolExecutor(1); --- End diff -- Yes it could be. That way, however, we support that we can use an arbitrary executor which is available (as you've mentioned for tests). Since refactoring wouldn't add much value, I'll keep it like this. ---