From issues-return-146978-archive-asf-public=cust-asf.ponee.io@flink.apache.org Tue Jan 9 14:38:03 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 2C207180718 for ; Tue, 9 Jan 2018 14:38:03 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 1BFF1160C2D; Tue, 9 Jan 2018 13:38:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 61B69160C13 for ; Tue, 9 Jan 2018 14:38:02 +0100 (CET) Received: (qmail 22687 invoked by uid 500); 9 Jan 2018 13:38:01 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 22678 invoked by uid 99); 9 Jan 2018 13:38:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jan 2018 13:38:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 16CBB1A06F4 for ; Tue, 9 Jan 2018 13:38:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.03 X-Spam-Level: X-Spam-Status: No, score=-4.03 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id uYkXJzRGyvMf for ; Tue, 9 Jan 2018 13:38:00 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 755AE5FB69 for ; Tue, 9 Jan 2018 13:37:59 +0000 (UTC) Received: (qmail 22640 invoked by uid 99); 9 Jan 2018 13:37:58 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jan 2018 13:37:58 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id A5742DFFCF; Tue, 9 Jan 2018 13:37:58 +0000 (UTC) From: GJL To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di... Content-Type: text/plain Message-Id: <20180109133758.A5742DFFCF@git1-us-west.apache.org> Date: Tue, 9 Jan 2018 13:37:58 +0000 (UTC) Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5184#discussion_r160407686 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -956,23 +958,29 @@ private void jobStatusChanged( "The job is registered as 'FINISHED (successful), but this notification describes " + "a failure, since the resulting accumulators could not be fetched.", e); - executor.execute(() ->jobCompletionActions.jobFailed(exception)); + executor.execute(() -> jobCompletionActions.jobFailed(builder + .serializedThrowable(new SerializedThrowable(exception)) + .build())); } break; case CANCELED: { final JobExecutionException exception = new JobExecutionException( jobID, "Job was cancelled.", new Exception("The job was cancelled")); - executor.execute(() -> jobCompletionActions.jobFailed(exception)); + executor.execute(() -> jobCompletionActions.jobFailed(builder + .serializedThrowable(new SerializedThrowable(exception)) + .build())); break; } case FAILED: { final Throwable unpackedError = SerializedThrowable.get(error, userCodeLoader); --- End diff -- I think `error` is always a `SerializedThrowable`. ``` private void notifyJobStatusChange(JobStatus newState, Throwable error) { if (jobStatusListeners.size() > 0) { final long timestamp = System.currentTimeMillis(); final Throwable serializedError = error == null ? null : new SerializedThrowable(error); for (JobStatusListener listener : jobStatusListeners) { try { listener.jobStatusChanges(getJobID(), newState, timestamp, serializedError); } catch (Throwable t) { LOG.warn("Error while notifying JobStatusListener", t); } } } } ``` Not sure if it makes sense to unpack, wrap, and serialize it again. ---