From issues-return-146549-archive-asf-public=cust-asf.ponee.io@flink.apache.org Mon Jan 8 11:16:23 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id B898D18072F for ; Mon, 8 Jan 2018 11:16:23 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A8687160C1E; Mon, 8 Jan 2018 10:16:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EBD23160C2C for ; Mon, 8 Jan 2018 11:16:22 +0100 (CET) Received: (qmail 73517 invoked by uid 500); 8 Jan 2018 10:16:22 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 73501 invoked by uid 99); 8 Jan 2018 10:16:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jan 2018 10:16:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A17D81805CC for ; Mon, 8 Jan 2018 10:16:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.03 X-Spam-Level: X-Spam-Status: No, score=-4.03 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ZorEJrAzFO53 for ; Mon, 8 Jan 2018 10:16:20 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id AB0A35F3DF for ; Mon, 8 Jan 2018 10:16:19 +0000 (UTC) Received: (qmail 73381 invoked by uid 99); 8 Jan 2018 10:16:18 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jan 2018 10:16:18 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4CA6FDFCB5; Mon, 8 Jan 2018 10:16:16 +0000 (UTC) From: GJL To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #5225: [FLINK-8339] [flip6] Let CustomCommandLine return ... Content-Type: text/plain Message-Id: <20180108101617.4CA6FDFCB5@git1-us-west.apache.org> Date: Mon, 8 Jan 2018 10:16:16 +0000 (UTC) Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5225#discussion_r160108309 --- Diff: flink-yarn/src/test/java/org/apache/flink/yarn/AbstractYarnClusterTest.java --- @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.yarn; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.util.Preconditions; +import org.apache.flink.util.TestLogger; + +import org.apache.hadoop.yarn.api.records.ApplicationAttemptId; +import org.apache.hadoop.yarn.api.records.ApplicationId; +import org.apache.hadoop.yarn.api.records.ApplicationReport; +import org.apache.hadoop.yarn.api.records.FinalApplicationStatus; +import org.apache.hadoop.yarn.api.records.YarnApplicationState; +import org.apache.hadoop.yarn.client.api.YarnClient; +import org.apache.hadoop.yarn.client.api.impl.YarnClientImpl; +import org.apache.hadoop.yarn.exceptions.YarnException; +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.TemporaryFolder; + +import java.io.IOException; +import java.util.Collections; +import java.util.Map; + +import static org.junit.Assert.fail; + +/** + * Tests for the {@link AbstractYarnClusterDescriptor}. + */ +public class AbstractYarnClusterTest extends TestLogger { + + @Rule + public TemporaryFolder temporaryFolder = new TemporaryFolder(); + + /** + * Tests that the cluster retrieval of a finished YARN application fails. + */ + @Test(expected = RuntimeException.class) + public void testClusterClientRetrievalOfFinishedYarnApplication() throws IOException { + final ApplicationId applicationId = ApplicationId.newInstance(System.currentTimeMillis(), 42); + final String clusterId = applicationId.toString(); + final ApplicationReport applicationReport = ApplicationReport.newInstance( + applicationId, + ApplicationAttemptId.newInstance(applicationId, 0), + "user", + "queue", + "name", + "localhost", + 42, + null, + YarnApplicationState.FINISHED, + null, + null, + 1L, + 2L, + FinalApplicationStatus.SUCCEEDED, + null, + null, + 1.0f, + null, + null); + + final YarnClient yarnClient = new TestingYarnClient(Collections.singletonMap(applicationId, applicationReport)); + + final TestingAbstractYarnClusterDescriptor clusterDescriptor = new TestingAbstractYarnClusterDescriptor( + new Configuration(), + temporaryFolder.newFolder().getAbsolutePath(), + yarnClient); + + clusterDescriptor.retrieve(clusterId); + + fail("We should not be able to retrieve ClusterClient for a finished Yarn application."); + } + + @Test + public void testClusterClientRetrievalFromInvalidYarnId() { --- End diff -- This test is empty. ---