Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: StefanRRichter <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4963-flink@git.apache.org>
In-Reply-To: <git-pr-4963-flink@git.apache.org>
Subject: [GitHub] flink pull request #4963: [FLINK-7475] [core][DataStream API] support update...
Content-Type: text/plain
Message-Id: <20180103094959.E9762DFD7B@git1-us-west.apache.org>
Date: Wed,  3 Jan 2018 09:49:59 +0000 (UTC)
archived-at: Wed, 03 Jan 2018 09:50:07 -0000

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4963#discussion_r159387906
  
    --- Diff: flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/util/MergeUtilsTest.java ---
    @@ -0,0 +1,46 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.contrib.streaming.state.util;
    +
    +import org.junit.Test;
    +
    +import java.util.ArrayList;
    +import java.util.Arrays;
    +import java.util.List;
    +
    +import static org.junit.Assert.assertTrue;
    +
    +/**
    + * Tests for MergeUtils.
    + */
    +public class MergeUtilsTest {
    +	@Test
    +	public void testMerge() {
    --- End diff --
    
    This test should cover more corner cases, like empty list, singleton list, ...


---