Return-Path: <issues-return-145827-archive-asf-public=cust-asf.ponee.io@flink.apache.org>
X-Original-To: archive-asf-public@eu.ponee.io
Delivered-To: archive-asf-public@eu.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by mx-eu-01.ponee.io (Postfix) with ESMTP id 3B296180630
	for <archive-asf-public@eu.ponee.io>; Tue,  2 Jan 2018 16:26:30 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 2B3B4160C26; Tue,  2 Jan 2018 15:26:30 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 73416160C1B
	for <archive-asf-public@cust-asf.ponee.io>; Tue,  2 Jan 2018 16:26:29 +0100 (CET)
Received: (qmail 40295 invoked by uid 500); 2 Jan 2018 15:26:28 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 40286 invoked by uid 99); 2 Jan 2018 15:26:28 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jan 2018 15:26:28 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 3DACA180705
	for <issues@flink.apache.org>; Tue,  2 Jan 2018 15:26:28 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -4.03
X-Spam-Level: 
X-Spam-Status: No, score=-4.03 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024)
	with ESMTP id 0EEdlnYb7XFk for <issues@flink.apache.org>;
	Tue,  2 Jan 2018 15:26:27 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id A32DC5FB3D
	for <issues@flink.incubator.apache.org>; Tue,  2 Jan 2018 15:26:26 +0000 (UTC)
Received: (qmail 40249 invoked by uid 99); 2 Jan 2018 15:26:25 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jan 2018 15:26:25 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id D1867DFE46; Tue,  2 Jan 2018 15:26:25 +0000 (UTC)
From: GJL <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-5223-flink@git.apache.org>
In-Reply-To: <git-pr-5223-flink@git.apache.org>
Subject: [GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...
Content-Type: text/plain
Message-Id: <20180102152625.D1867DFE46@git1-us-west.apache.org>
Date: Tue,  2 Jan 2018 15:26:25 +0000 (UTC)
archived-at: Tue, 02 Jan 2018 15:26:30 -0000

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5223#discussion_r159247245
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcUtils.java ---
    @@ -27,11 +27,16 @@
     import java.util.concurrent.TimeoutException;
     
     /**
    - * Utility functions for Flink's RPC implementation
    + * Utility functions for Flink's RPC implementation.
      */
     public class RpcUtils {
     
    -	public static final Time INF_TIMEOUT = Time.milliseconds(Long.MAX_VALUE);
    +	/**
    +	 * <b>HACK:</b> Set to 21474835 seconds, Akka's maximum delay (Akka 2.4.20). The value cannot be
    +	 * higher or an {@link IllegalArgumentException} will be thrown during an RPC. Check the private
    +	 * method {@code checkMaxDelay()} in {@link akka.actor.LightArrayRevolverScheduler}.
    +	 */
    +	public static final Time INF_TIMEOUT = Time.milliseconds(TimeUnit.SECONDS.toMillis(21474835));
    --- End diff --
    
    `Time.seconds(21474835)`


---