Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 70AE2180630 for ; Tue, 2 Jan 2018 15:33:30 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 60D42160C38; Tue, 2 Jan 2018 14:33:30 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A8F79160C26 for ; Tue, 2 Jan 2018 15:33:29 +0100 (CET) Received: (qmail 41535 invoked by uid 500); 2 Jan 2018 14:33:28 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 41526 invoked by uid 99); 2 Jan 2018 14:33:28 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jan 2018 14:33:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 746C41A004B for ; Tue, 2 Jan 2018 14:33:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.03 X-Spam-Level: X-Spam-Status: No, score=-4.03 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id PBxUDJQxqNwT for ; Tue, 2 Jan 2018 14:33:27 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 6AC795F3B5 for ; Tue, 2 Jan 2018 14:33:27 +0000 (UTC) Received: (qmail 41215 invoked by uid 99); 2 Jan 2018 14:33:27 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jan 2018 14:33:27 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 3B6BCE2F42; Tue, 2 Jan 2018 14:33:26 +0000 (UTC) From: pnowojski To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #5193: [FLINK-8268][tests] Improve tests stability Content-Type: text/plain Message-Id: <20180102143326.3B6BCE2F42@git1-us-west.apache.org> Date: Tue, 2 Jan 2018 14:33:26 +0000 (UTC) archived-at: Tue, 02 Jan 2018 14:33:30 -0000 Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5193#discussion_r159224671 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java --- @@ -179,9 +179,6 @@ public void testFailBeforeNotify() throws Exception { harness.initializeState(snapshot); assertExactlyOnce(Arrays.asList("42", "43")); - closeTestHarness(); - - assertEquals(0, tmpDirectory.listFiles().size()); --- End diff -- restored. ---