flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StevenLangbroek <...@git.apache.org>
Subject [GitHub] flink pull request #5264: [FLINK-8352][web-dashboard] Flink UI Reports No Er...
Date Mon, 08 Jan 2018 16:32:56 GMT
GitHub user StevenLangbroek opened a pull request:

    https://github.com/apache/flink/pull/5264

    [FLINK-8352][web-dashboard] Flink UI Reports No Error on Job Submission Failures

    ## What is the purpose of the change
    
    Report Job submission failures to Flink UI users.
    
    ## Brief change log
    
    When running a newly uploaded job, we trigger the `run` endpoint. This XHR request goes
through Angular's `$http` server, but is converted to a promise through the library `q`. The
"error" case isn't handled however, so the promise is never rejected, and so the error state
is never propagated to the UI. 
    
    ## Verifying this change
    
    Run the Flink UI locally, then upload the `SocketWindowWordCount.jar`, and start it without
changing any configuration.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StevenLangbroek/flink flink_8352_job_failure

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5264.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5264
    
----
commit 33f0170627e82eb76eb08044383512ff9a9130d9
Author: Steven Langbroek <steven@...>
Date:   2018-01-08T16:27:15Z

    [FLINK-8352] Flink UI Reports No Error on Job Submission Failures

----


---

Mime
View raw message