flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #5259: [FLINK-8252][benchmarks] convert network benchmark...
Date Mon, 08 Jan 2018 14:53:48 GMT
GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/5259

    [FLINK-8252][benchmarks] convert network benchmarks to streaming benchmarks

    ## What is the purpose of the change
    
    This converts the benchmarks created with #5134 and #5255 into proper streaming benchmarks
including the output flusher's timeout as a benchmark parameter.
    
    ## Brief change log
    
    - move benchmarks to the `flink-streaming-java` project
    - add the `flushTimeout` benchmark parameter
    
    ## Verifying this change
    
    The defined benchmarks can be run manually and are auto-executed by flink-benchmarks (dataArtisans/flink-benchmarks#3).
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: **no**
      - The S3 file system connector: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **not applicable**

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-8252

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5259.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5259
    
----
commit fada3022186670851a3956a961f490e6d86e2a53
Author: Nico Kruber <nico@...>
Date:   2017-12-13T14:28:08Z

    [hotfix][checkstyle] only ignore checkstyle in existing packages under runtime.io.network
    
    - ignore runtime.io.(async|disk)
    - ignore runtime.io.network.(api|buffer|netty|partition|serialization|util)
    -> everything else will be checked against the ruleset
    - fix checkstyle errors in classes directly under runtime.io.network

commit f8dff47a707c4e7572d02e072197927ec2ce2ef7
Author: Nico Kruber <nico@...>
Date:   2017-12-14T16:30:19Z

    [FLINK-8252][benchmarks] convert network benchmarks to streaming benchmarks
    
    This allows us to use the output flushing interval as a parameter to evaluate,
    too.

----


---

Mime
View raw message